public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dpu: Don't use %pK through printk (again)
Date: Tue, 24 Feb 2026 10:32:44 +1000	[thread overview]
Message-ID: <review-overall-20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de> (raw)
In-Reply-To: <20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de>

Overall Series Review

Subject: drm/msm/dpu: Don't use %pK through printk (again)
Author: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>
Patches: 2
Reviewed: 2026-02-24T10:32:44.728650

---

This is a single-patch series that changes a `%pK` format specifier to `%p` in a DRM_ERROR() call in the MSM DPU DSPP driver. The motivation is well-established kernel policy: since commit ad67b74d2469, regular `%p` hashes pointer values in printk output, making `%pK` unnecessary. Worse, `%pK` was never designed for use through printk and can leak raw pointers or take sleeping locks in atomic contexts.

The patch is trivially correct. It has already received a Reviewed-by from Dmitry Baryshkov. No issues found.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-24  0:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  7:16 [PATCH] drm/msm/dpu: Don't use %pK through printk (again) Thomas Weißschuh
2026-02-23 23:31 ` Dmitry Baryshkov
2026-02-24  0:32 ` Claude review: " Claude Code Review Bot
2026-02-24  0:32 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260223-restricted-pointers-msm-v1-1-14c0b451e372@linutronix.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox