From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: enable separate_gpu_kms by default Date: Mon, 23 Feb 2026 05:46:34 +1000 Message-ID: In-Reply-To: <20260223-seperate_gpu_kms-v1-1-e8231e7f1685@oss.qualcomm.com> References: <20260223-seperate_gpu_kms-v1-1-e8231e7f1685@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: enable separate_gpu_kms by default Author: Mahadevan P Patches: 1 Reviewed: 2026-02-23T05:46:34.073865 --- This is a single-patch series that changes the default value of the `separate_gpu_kms` module parameter in the MSM DRM driver from `false` to `true`. The effect is to decouple GPU and display subsystem probing by default, so each display subsystem initializes independently rather than the GPU binding to the first display subsystem that probes. The commit message explains the motivation: on multi-display targets like SA8775P, the old default prevents subsequent display subsystems from probing. The change itself is trivially correct -- it flips a boolean default. However, the `MODULE_PARM_DESC` string becomes inaccurate after this change, and there is a pre-existing naming mismatch between the description and the parameter that this patch should address while it is changing the default. The patch also declares dependencies on two other patch series. Whether this default change is safe without those dependencies being merged first is an important consideration that isn't addressed in the commit message. --- Generated by Claude Code Patch Reviewer