public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers
Date: Tue, 24 Feb 2026 10:48:42 +1000	[thread overview]
Message-ID: <review-overall-20260223043441.5295-1-chintanlike@gmail.com> (raw)
In-Reply-To: <20260223043441.5295-1-chintanlike@gmail.com>

Overall Series Review

Subject: drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers
Author: Chintan Patel <chintanlike@gmail.com>
Patches: 2
Reviewed: 2026-02-24T10:48:42.972211

---

This is a single-patch series converting the panel-novatek-nt36672a driver from the deprecated `mipi_dsi_dcs_write()` API to the newer `mipi_dsi_*_multi()` helpers with `mipi_dsi_multi_context` error accumulation. This is a standard modernization cleanup that many panel drivers have undergone.

The conversion is largely straightforward but contains one clear sequencing bug in `nt36672a_panel_unprepare()`: the enter-sleep-mode command has been moved before the 120ms delay, whereas the original code (and the DCS spec, per the existing comment) placed it after. Doug Anderson already identified this in his on-list reply. There is also a subtler issue where the error accumulation semantics in unprepare cause `set_display_off` to be skipped if the preceding off-commands fail, which differs from the original best-effort-everything behavior.

The prepare() conversion is mostly correct but could be tightened up, as Doug also noted. The `nt36672a_panel_power_off()` return value is now silently discarded.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-24  0:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  4:34 [PATCH] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers Chintan Patel
2026-02-23 21:33 ` Doug Anderson
2026-02-24  0:48 ` Claude Code Review Bot [this message]
2026-02-24  0:48 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03  3:55 [PATCH v2] " Chintan Patel
2026-03-03 21:58 ` Claude review: " Claude Code Review Bot
2026-03-03 21:58 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260223043441.5295-1-chintanlike@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox