From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu/drm: panel: add support for DSI panel used in Motorola Atrix 4G and Droid X2 Date: Tue, 24 Feb 2026 10:38:13 +1000 Message-ID: In-Reply-To: <20260223064630.12720-1-clamor95@gmail.com> References: <20260223064630.12720-1-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu/drm: panel: add support for DSI panel used in Motorola Atrix 4G and Droid X2 Author: Svyatoslav Ryhel Patches: 3 Reviewed: 2026-02-24T10:38:13.651516 --- This is a two-patch series adding support for a DSI LCD panel used in Motorola Atrix 4G and Droid X2 smartphones. The first patch adds the devicetree binding documentation and the second adds the panel driver. The panel is 540x960, 24-bit RGB, connected via DSI with 2 lanes. The vendor and model are unknown, so a generic compatible based on the board name "Mot" is used. The driver follows modern panel driver conventions: it uses `devm_drm_panel_alloc`, the `mipi_dsi_multi_context` pattern for init sequences, `devm_regulator_bulk_get_const`, and `drm_connector_helper_get_modes_fixed`. The overall structure is clean. There is one significant concern: the Kconfig help text describes this as a "video mode panel" but the driver only sets `MIPI_DSI_MODE_LPM` in the DSI mode flags, which means the panel will operate in command mode. Either the description is inaccurate or the flag `MIPI_DSI_MODE_VIDEO` is missing. There is also a resource leak on the error path in prepare. --- Generated by Claude Code Patch Reviewer