From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: tegra: document Tegra20 HDMI port Date: Tue, 24 Feb 2026 10:34:48 +1000 Message-ID: In-Reply-To: <20260223065500.13357-1-clamor95@gmail.com> References: <20260223065500.13357-1-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: ARM: tegra: document Tegra20 HDMI port Author: Svyatoslav Ryhel Patches: 3 Reviewed: 2026-02-24T10:34:48.093002 --- This is a straightforward two-patch device tree series that adds OF graph port support to the Tegra HDMI binding and converts the ASUS TF600T DTS to use an explicit `hdmi-connector` node instead of inline HPD/DDC properties. The approach is standard for modeling HDMI outputs through the connector framework, moving the hotplug detect GPIO and DDC I2C bus from the HDMI encoder node to a separate connector node connected via OF graph endpoints. The binding change in patch 1 uses `anyOf` to preserve backward compatibility -- existing DTS files with `nvidia,hpd-gpio` and `nvidia,ddc-i2c-bus` remain valid, while new DTS files can use the `port` property instead. The DTS change in patch 2 correctly uses the `hdmi-connector` binding with type `"d"` (micro HDMI) and valid properties. There are a couple of minor observations but no significant correctness issues in the series. --- Generated by Claude Code Patch Reviewer