From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register
Date: Tue, 24 Feb 2026 10:09:17 +1000 [thread overview]
Message-ID: <review-overall-20260223141638.2022490-1-l.scorcia@gmail.com> (raw)
In-Reply-To: <20260223141638.2022490-1-l.scorcia@gmail.com>
Overall Series Review
Subject: drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Patches: 1
Reviewed: 2026-02-24T10:09:17.084197
---
This is a single-patch fix for a NULL pointer dereference during mediatek-drm DSI probe. The bug is straightforward: commit e4732b590a77 rearranged the probe sequence so that `mipi_dsi_host_register()` is called before `platform_set_drvdata()`, but `mipi_dsi_host_register()` can synchronously trigger `mtk_dsi_host_attach()` -> `component_add()` -> `mtk_dsi_bind()`, which calls `dev_get_drvdata()` and dereferences the result. Since drvdata is still NULL at that point, the kernel crashes.
The fix is minimal and correct: move `platform_set_drvdata(pdev, dsi)` before the `mipi_dsi_host_register()` call. The commit message is well-written, includes the full crash trace for reference, and has an appropriate Fixes tag.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-24 0:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 14:16 [PATCH v2] drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Luca Leonardo Scorcia
2026-02-24 0:09 ` Claude Code Review Bot [this message]
2026-02-24 0:09 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 9:38 [PATCH v3] " Luca Leonardo Scorcia
2026-02-27 3:42 ` Claude review: " Claude Code Review Bot
2026-02-27 3:42 ` Claude Code Review Bot
2026-03-20 15:37 [PATCH v3 RESEND] " Luca Leonardo Scorcia
2026-03-21 17:36 ` Claude review: " Claude Code Review Bot
2026-03-21 17:36 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260223141638.2022490-1-l.scorcia@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox