From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tiny: ili9486: use DRM_MODE_INIT for proper vrefresh Date: Tue, 24 Feb 2026 10:01:43 +1000 Message-ID: In-Reply-To: <20260223171247.503277-1-mail@singulared.space> References: <20260223171247.503277-1-mail@singulared.space> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/tiny: ili9486: use DRM_MODE_INIT for proper vrefresh Author: Belousov Maksim Patches: 1 Reviewed: 2026-02-24T10:01:43.534737 --- This is a single-patch series that fixes the display mode definition in the= ili9486 tiny DRM driver. The driver currently uses `DRM_SIMPLE_MODE()` whi= ch sets a dummy pixel clock of 1 kHz, resulting in a calculated vrefresh of= approximately 0.006 Hz. The patch replaces it with `DRM_MODE_INIT(30, ...)= ` which computes a pixel clock that yields a 30 Hz vrefresh value. The commit message is well-written and provides concrete evidence of the pr= oblem: Weston logs abnormal repaint delay warnings, and GTK4 clients under = wlroots-based compositors fail to visually update because they use the repo= rted refresh rate for scheduling. The fix is minimal and appropriate =E2=80= =94 a single macro substitution with no behavioral side effects beyond the = mode metadata. The pixel clock calculation (`480 * 320 * 30 / 1000 =3D 4608= kHz`) is correct and produces the intended 30 Hz vrefresh. No issues found. --- Generated by Claude Code Patch Reviewer