From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Date: Tue, 24 Feb 2026 09:59:59 +1000 Message-ID: In-Reply-To: <20260223172120.98961-6-jonathan.cavitt@intel.com> References: <20260223172120.98961-6-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Author: Jonathan Cavitt Patches: 5 Reviewed: 2026-02-24T09:59:59.947544 --- This is v35 of a 4-patch series that adds a new `DRM_IOCTL_XE_VM_GET_PROPERTY` ioctl to the xe driver, allowing userspace to query per-VM properties, starting with a list of failed page faults. The series is structured as: (1) a bugfix rejecting write/atomic access to read-only VMAs during page fault handling, (2) UAPI definitions, (3) kernel-side fault recording infrastructure, and (4) the ioctl implementation. The overall design is reasonable: failed page faults are captured into a per-VM list capped at 50 entries, and userspace queries them through a two-phase ioctl (first query size, then retrieve data). However, the series has a critical build-breaking bug in patch 3 that references non-existent struct fields and undefined macros. Additionally, the UAPI definitions have naming convention issues -- the `struct xe_vm_fault` and its associated `FAULT_*` defines don't follow the established `drm_xe_` / `DRM_XE_` naming convention used throughout the rest of xe_drm.h. The ioctl handler in patch 4 also fails to validate the `pad` and `extensions` fields of the input struct, which is a UAPI contract violation that must be fixed before merge. --- Generated by Claude Code Patch Reviewer