public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/selftests: Fix build after dma-fence locking rework
Date: Tue, 24 Feb 2026 09:54:10 +1000	[thread overview]
Message-ID: <review-overall-20260223172553.1663749-1-matthew.brost@intel.com> (raw)
In-Reply-To: <20260223172553.1663749-1-matthew.brost@intel.com>

Overall Series Review

Subject: drm/i915/selftests: Fix build after dma-fence locking rework
Author: Matthew Brost <matthew.brost@intel.com>
Patches: 7
Reviewed: 2026-02-24T09:54:10.645046

---

This is a single-patch build fix for the i915_active selftest, needed after a dma-fence locking rework that inlined the spinlock into `struct dma_fence` and introduced a `dma_fence_spinlock()` accessor. The patch mechanically replaces two instances of direct `fence->lock` access with the new accessor. The change is minimal, correct, and already has Christian König's Reviewed-by.

The mailing list discussion following the patch is more interesting than the patch itself. Christian raised a pre-existing question about the use of `spin_lock_irq()` vs `spin_lock_irqsave()` in `active_flush()`, and a lockdep splat was reported in `dma_fence_chain_enable_signaling()` that Christian identified as a pre-existing bug newly exposed by the locking rework. Neither issue is introduced by this patch.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-23 23:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 17:25 [PATCH] drm/i915/selftests: Fix build after dma-fence locking rework Matthew Brost
2026-02-23 19:01 ` Cavitt, Jonathan
2026-02-23 19:13 ` Christian König
2026-02-23 19:20   ` Matthew Brost
2026-02-23 19:33     ` Christian König
2026-02-23 19:36       ` Matthew Brost
2026-02-23 20:03         ` Christian König
2026-02-23 23:54 ` Claude review: " Claude Code Review Bot
2026-02-23 23:54 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260223172553.1663749-1-matthew.brost@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox