From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/selftests: Fix build after dma-fence locking rework Date: Tue, 24 Feb 2026 09:54:10 +1000 Message-ID: In-Reply-To: <20260223172553.1663749-1-matthew.brost@intel.com> References: <20260223172553.1663749-1-matthew.brost@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915/selftests: Fix build after dma-fence locking rework Author: Matthew Brost Patches: 7 Reviewed: 2026-02-24T09:54:10.645046 --- This is a single-patch build fix for the i915_active selftest, needed after= a dma-fence locking rework that inlined the spinlock into `struct dma_fenc= e` and introduced a `dma_fence_spinlock()` accessor. The patch mechanically= replaces two instances of direct `fence->lock` access with the new accesso= r. The change is minimal, correct, and already has Christian K=C3=B6nig's R= eviewed-by. The mailing list discussion following the patch is more interesting than th= e patch itself. Christian raised a pre-existing question about the use of `= spin_lock_irq()` vs `spin_lock_irqsave()` in `active_flush()`, and a lockde= p splat was reported in `dma_fence_chain_enable_signaling()` that Christian= identified as a pre-existing bug newly exposed by the locking rework. Neit= her issue is introduced by this patch. --- Generated by Claude Code Patch Reviewer