From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Clarify driver/device type names Date: Tue, 24 Feb 2026 09:38:58 +1000 Message-ID: In-Reply-To: <20260223204648.208886-1-deborah.brouwer@collabora.com> References: <20260223204648.208886-1-deborah.brouwer@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/tyr: Clarify driver/device type names Author: Deborah Brouwer Patches: 2 Reviewed: 2026-02-24T09:38:58.622564 --- This is a single-patch submission for the Rust-based DRM "tyr" driver (Arm Mali Tyr GPU). The patch is a pure rename/refactoring with no functional changes. It addresses the fact that the `TyrDriver` struct was previously pulling double duty, implementing both `platform::Driver` and `drm::Driver`. The patch introduces a new empty unit struct `TyrDrmDriver` to carry the `drm::Driver` implementation, and renames the original `TyrDriver` to `TyrPlatformDeviceData` to reflect its role as the data stored in the platform device. The renaming is mechanically correct and all references are updated consistently. The architectural split is reasonable -- separating the platform driver data from the DRM driver trait implementation makes the code's intent clearer. Danilo Krummrich already provided feedback on the naming convention for `TyrPlatformDeviceData`, suggesting `TyrPlatformDriverData` to align with the C-side `platform_set_drvdata()` naming, which seems right. There is one minor inconsistency worth noting: the patch defines the `TyrDrmDevice` type alias in driver.rs but does not use it in the other files where it would apply. --- Generated by Claude Code Patch Reviewer