From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/pagemap: Unlock cache->lock before freeing it
Date: Tue, 24 Feb 2026 09:36:36 +1000 [thread overview]
Message-ID: <review-overall-20260223222937.2008492-1-matthew.brost@intel.com> (raw)
In-Reply-To: <20260223222937.2008492-1-matthew.brost@intel.com>
Overall Series Review
Subject: drm/pagemap: Unlock cache->lock before freeing it
Author: Matthew Brost <matthew.brost@intel.com>
Patches: 1
Reviewed: 2026-02-24T09:36:36.206852
---
This is a single patch that adds a missing `spin_unlock(&cache->lock)` call in the `else` branch of `drm_pagemap_cache_fini()`. When `drm_pagemap_shrinker_cancel()` returns false (meaning the shrinker has already dequeued the pagemap), the code falls through to the `out:` label with the spinlock still held, and then proceeds to `kfree(cache)`, freeing the lock while still held.
The fix is straightforward and correct for what it claims to do. The commit message describes this as satisfying static analyzers, though it's worth noting that `CONFIG_DEBUG_SPINLOCK` / lockdep builds will also warn about freeing a held spinlock, so this is arguably a real (debug) bug, not just a static analysis false positive.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-23 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 22:29 [PATCH] drm/pagemap: Unlock cache->lock before freeing it Matthew Brost
2026-02-23 23:36 ` Claude review: " Claude Code Review Bot
2026-02-23 23:36 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260223222937.2008492-1-matthew.brost@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox