From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vc4: platform_get_irq_byname() returns an int
Date: Tue, 24 Feb 2026 10:07:38 +1000 [thread overview]
Message-ID: <review-overall-2026022339-cornflake-t-shirt-2471@gregkh> (raw)
In-Reply-To: <2026022339-cornflake-t-shirt-2471@gregkh>
Overall Series Review
Subject: drm/vc4: platform_get_irq_byname() returns an int
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Patches: 1
Reviewed: 2026-02-24T10:07:38.188288
---
This is a single-patch fix from Greg Kroah-Hartman correcting the return type handling of `platform_get_irq_byname()` in the vc4 HDMI driver. The original code stored the return value in `unsigned int` variables, which silently converted negative error codes into large positive values that would then be passed to `devm_request_threaded_irq()`. The fix changes the type to `int` and adds proper error checking before each use.
The fix is correct and well-structured. The caller at `vc4_hdmi_bind()` already checks the return value of `vc4_hdmi_hotplug_init()` and handles errors appropriately. No issues found.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-24 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 15:53 [PATCH] drm/vc4: platform_get_irq_byname() returns an int Greg Kroah-Hartman
2026-02-24 0:07 ` Claude Code Review Bot [this message]
2026-02-24 0:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-2026022339-cornflake-t-shirt-2471@gregkh \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox