From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vc4: platform_get_irq_byname() returns an int Date: Tue, 24 Feb 2026 10:07:38 +1000 Message-ID: In-Reply-To: <2026022339-cornflake-t-shirt-2471@gregkh> References: <2026022339-cornflake-t-shirt-2471@gregkh> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/vc4: platform_get_irq_byname() returns an int Author: Greg Kroah-Hartman Patches: 1 Reviewed: 2026-02-24T10:07:38.188288 --- This is a single-patch fix from Greg Kroah-Hartman correcting the return type handling of `platform_get_irq_byname()` in the vc4 HDMI driver. The original code stored the return value in `unsigned int` variables, which silently converted negative error codes into large positive values that would then be passed to `devm_request_threaded_irq()`. The fix changes the type to `int` and adds proper error checking before each use. The fix is correct and well-structured. The caller at `vc4_hdmi_bind()` already checks the return value of `vc4_hdmi_hotplug_init()` and handles errors appropriately. No issues found. --- Generated by Claude Code Patch Reviewer