From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Date: Fri, 27 Feb 2026 14:54:14 +1000 Message-ID: In-Reply-To: <20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com> References: <20260224-drm-amdkfd-ttmp11-sched-mode-v1-1-4254ff8952c4@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Author: Peter Colberg Patches: 1 Reviewed: 2026-02-27T14:54:14.464602 --- This is a single, straightforward cleanup patch. The original commit `bbcad5a8896b` introduced duplicate definitions of `TTMP11_SCHED_MODE_SHIFT`, `TTMP11_SCHED_MODE_SIZE`, and `TTMP11_SCHED_MODE_MASK` in `cwsr_trap_handler_gfx12.asm`. One copy was inside an `#if RELAXED_SCHEDULING_IN_TRAP` guard, the other was unconditional. Since all uses of these variables are within `#if RELAXED_SCHEDULING_IN_TRAP` blocks, the unconditional copy was unnecessary and the guarded copy was redundant. The patch removes the first (guarded) copy and adds `#if RELAXED_SCHEDULING_IN_TRAP` / `#endif` guards around the second (previously unconditional) copy. This keeps the definitions grouped with the other `TTMP11_*` variables, which is the better location. **Verdict: Looks good.** Clean, minimal, and correct. --- Generated by Claude Code Patch Reviewer