Claude review: drm/atomic: Allocate drm_private_state through a callback

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/atomic: Allocate drm_private_state through a callback
Author: Maxime Ripard <mripard@kernel.org>
Patches: 5
Reviewed: 2026-02-27T15:05:36.753298

---

**Series: drm/atomic: Allocate drm_private_state through a callback (v5)**
**Author: Maxime Ripard <mripard@kernel.org>**

This is a well-structured and logical cleanup series. It converts the three remaining `drm_private_obj` users (amdgpu, omapdrm, tegra) from the old pattern of externally allocating and passing state to `drm_atomic_private_obj_init()`, to the newer `atomic_create_state` callback pattern. Once all users are converted, patch 4 removes the now-unnecessary `state` parameter.

The series is sensible and follows the established direction for the DRM atomic API. The driver conversions are mechanical and straightforward. However, there is one significant issue: **none of the three driver patches check the return value of `drm_atomic_private_obj_init()`**, which can now fail when it internally calls `atomic_create_state`. There is also a cosmetic issue with the cover letter.

**Overall verdict**: Needs minor fixes for return value checking before merging.

---

---
Generated by Claude Code Patch Reviewer