From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: add support for j721e,j784s4,j722s,am62p Date: Fri, 27 Feb 2026 14:48:57 +1000 Message-ID: In-Reply-To: <20260224-gpu_dts-v1-0-cc5ddffe140c@ti.com> References: <20260224-gpu_dts-v1-0-cc5ddffe140c@ti.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/imagination: add support for j721e,j784s4,j722s,am62p Author: Antonios Christidis Patches: 9 Reviewed: 2026-02-27T14:48:57.776869 --- This is a 5-patch series adding GPU device tree nodes for TI K3 SoCs (J721E, J784S4, J722S/AM62P) to enable the Imagination/PowerVR GPU driver, plus a clock framework fix. The series is authored by Antonios Christidis (TI) and includes two patches originally from Michael Walle. **Overall assessment: Needs minor revisions.** The patches are straightforward DTS additions with reasonable content, but there are ordering issues, a missing blank line in the binding patch, inconsistencies between the DTS nodes across patches, and a vague subject line. **Key concerns:** 1. **Patch ordering**: The DT binding (patch 2) should come *before* the DTS that uses the new compatible (patch 1), per kernel convention. 2. **Inconsistencies** across DTS nodes: patch 4 is missing `assigned-clocks`/`assigned-clock-rates` and `dma-coherent` compared to patches 1 and 3. This may be intentional but needs clarification. 3. **Patch 5 (clock fix)** is a functional fix that other patches depend on and arguably belongs at the start of the series or in a separate submission. 4. Missing `status = "disabled"` on all GPU nodes -- if the convention for this platform is to leave nodes disabled and enable per-board, this should be added. --- --- Generated by Claude Code Patch Reviewer