Claude review: Add lontium lt8713sx bridge driver

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add lontium lt8713sx bridge driver
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
Patches: 5
Reviewed: 2026-02-27T14:52:51.928511

---

This is a v4 of a driver for the Lontium LT8713SX, a Type-C/DP1.4 to DP1.4/HDMI2.0/DP++ bridge hub. The series consists of a DT binding and a driver that provides **only firmware upgrade functionality** via a sysfs attribute, plus a minimal `drm_bridge` attachment so the chip sits in the bridge chain. The chip itself apparently handles the actual DP MST/conversion in hardware once firmware is loaded.

**Key concerns:**

1. **The driver is essentially a firmware flasher exposed via a raw sysfs attribute**, not a real bridge driver. It implements no bridge operations beyond `attach` — no mode validation, no enable/disable, no detect, no EDID reading. The sysfs-based firmware update approach is unusual and should use the standard Linux firmware update mechanisms (e.g., `request_firmware_nowait` at probe, or the firmware upload API). Using a hand-rolled sysfs attribute for firmware flashing is fragile and non-standard.

2. **Several correctness issues** exist: the DT binding is missing properties that the driver consumes, `enable_gpio` is obtained but never used, the `drm_bridge_attach` signature change hasn't been properly adapted, error-path resource management is fragile, and there are integer type issues.

3. **The CRC table is global and mutable** (`DECLARE_CRC8_TABLE` is a static global array), but `crc8_populate_msb` is only called in `probe()`. If two devices probe concurrently, or if the table is used before probe completes, this is a race.

**Recommendation: Needs significant rework** before it is ready for merge.

---

---
Generated by Claude Code Patch Reviewer