From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add lontium lt8713sx bridge driver Date: Fri, 27 Feb 2026 14:52:51 +1000 Message-ID: In-Reply-To: <20260224-lt8713sx-bridge-driver-v4-0-b5603f5458d8@oss.qualcomm.com> References: <20260224-lt8713sx-bridge-driver-v4-0-b5603f5458d8@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add lontium lt8713sx bridge driver Author: Vishnu Saini Patches: 5 Reviewed: 2026-02-27T14:52:51.928511 --- This is a v4 of a driver for the Lontium LT8713SX, a Type-C/DP1.4 to DP1.4/= HDMI2.0/DP++ bridge hub. The series consists of a DT binding and a driver t= hat provides **only firmware upgrade functionality** via a sysfs attribute,= plus a minimal `drm_bridge` attachment so the chip sits in the bridge chai= n. The chip itself apparently handles the actual DP MST/conversion in hardw= are once firmware is loaded. **Key concerns:** 1. **The driver is essentially a firmware flasher exposed via a raw sysfs a= ttribute**, not a real bridge driver. It implements no bridge operations be= yond `attach` =E2=80=94 no mode validation, no enable/disable, no detect, n= o EDID reading. The sysfs-based firmware update approach is unusual and sho= uld use the standard Linux firmware update mechanisms (e.g., `request_firmw= are_nowait` at probe, or the firmware upload API). Using a hand-rolled sysf= s attribute for firmware flashing is fragile and non-standard. 2. **Several correctness issues** exist: the DT binding is missing properti= es that the driver consumes, `enable_gpio` is obtained but never used, the = `drm_bridge_attach` signature change hasn't been properly adapted, error-pa= th resource management is fragile, and there are integer type issues. 3. **The CRC table is global and mutable** (`DECLARE_CRC8_TABLE` is a stati= c global array), but `crc8_populate_msb` is only called in `probe()`. If tw= o devices probe concurrently, or if the table is used before probe complete= s, this is a race. **Recommendation: Needs significant rework** before it is ready for merge. --- --- Generated by Claude Code Patch Reviewer