From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: platform/x86/intel/vsec: Prep for ACPI PMT discovery Date: Fri, 27 Feb 2026 14:12:35 +1000 Message-ID: In-Reply-To: <20260224-upstream-pmt-acpi-v5-v5-0-8dd73bcf049c@linux.intel.com> References: <20260224-upstream-pmt-acpi-v5-v5-0-8dd73bcf049c@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: platform/x86/intel/vsec: Prep for ACPI PMT discovery Author: "David E. Box" Patches: 7 Reviewed: 2026-02-27T14:12:35.971128 --- This is a well-structured 6-patch series by David E. Box that prepares the Intel VSEC subsystem for ACPI-based PMT discovery. The series progressively decouples the vsec layer from PCI-specific types, improves const-correctness and error handling, and finally adds ACPI discovery table plumbing. The patch ordering is logical and each patch has a clear purpose. The series is mostly clean with good incremental refactoring. However, there are a few issues worth addressing, particularly around safety in patch 4's PCI-to-device conversion (unchecked `to_pci_dev()` calls in downstream consumers), a semantic change in error handling in patch 5, and a potential resource leak in patch 6. --- --- Generated by Claude Code Patch Reviewer