* [PATCH v1] drm/ci: add sc7180-trogdor-wormdingler-rev1-boe
@ 2026-02-24 8:10 Vignesh Raman
2026-02-27 5:32 ` Claude review: " Claude Code Review Bot
2026-02-27 5:32 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Vignesh Raman @ 2026-02-24 8:10 UTC (permalink / raw)
To: dri-devel
Cc: daniels, helen.fornazier, airlied, simona.vetter,
dmitry.baryshkov, lumag, robdclark, robin.clark, guilherme.gallo,
sergi.blanch.torne, valentine.burley, linux-arm-msm, linux-kernel
Add job that executes the IGT test suite for
sc7180-trogdor-wormdingler-rev1-boe.
Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---
v1:
- https://gitlab.freedesktop.org/drm/msm/-/merge_requests/221
- Depends on https://lore.kernel.org/dri-devel/20260210071138.2256773-1-vignesh.raman@collabora.com/
---
drivers/gpu/drm/ci/arm64.config | 4 +++
drivers/gpu/drm/ci/build.sh | 1 +
drivers/gpu/drm/ci/test.yml | 10 +++++++
...180-trogdor-wormdingler-rev1-boe-fails.txt | 23 ++++++++++++++
...180-trogdor-wormdingler-rev1-boe-skips.txt | 30 +++++++++++++++++++
5 files changed, 68 insertions(+)
create mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-fails.txt
create mode 100644 drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-skips.txt
diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config
index 5da3913ec8a4..a0ced4df7d79 100644
--- a/drivers/gpu/drm/ci/arm64.config
+++ b/drivers/gpu/drm/ci/arm64.config
@@ -214,3 +214,7 @@ CONFIG_PWM_TEGRA=y
CONFIG_DRM_PANTHOR=m
CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=y
CONFIG_PHY_ROCKCHIP_SAMSUNG_HDPTX=y
+
+# For sc7180-trogdor-wormdingler-rev1-boe
+CONFIG_DRM_PANEL_BOE_TV101WUM_NL6=y
+CONFIG_GPIO_SHARED_PROXY=y
diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
index d00d549cbd9c..5a3f3615f773 100644
--- a/drivers/gpu/drm/ci/build.sh
+++ b/drivers/gpu/drm/ci/build.sh
@@ -29,6 +29,7 @@ if [[ "$KERNEL_ARCH" = "arm64" ]]; then
DEVICE_TREES+=" arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb"
DEVICE_TREES+=" arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtb"
DEVICE_TREES+=" arch/arm64/boot/dts/qcom/sm8350-hdk.dtb"
+ DEVICE_TREES+=" arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb"
elif [[ "$KERNEL_ARCH" = "arm" ]]; then
GCC_ARCH="arm-linux-gnueabihf"
DEBIAN_ARCH="armhf"
diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
index f6bee5b67931..9d24686df5bf 100644
--- a/drivers/gpu/drm/ci/test.yml
+++ b/drivers/gpu/drm/ci/test.yml
@@ -122,6 +122,16 @@ msm:sc7180-trogdor-kingoftown:
GPU_VERSION: ${DEVICE_TYPE}
RUNNER_TAG: mesa-ci-x86-64-lava-sc7180-trogdor-kingoftown
+msm:sc7180-trogdor-wormdingler:
+ extends:
+ - .msm-sc7180
+ parallel: 6
+ variables:
+ DEVICE_TYPE: sc7180-trogdor-wormdingler-rev1-boe
+ DTB: sc7180-trogdor-wormdingler-rev1-boe
+ GPU_VERSION: ${DEVICE_TYPE}
+ RUNNER_TAG: mesa-ci-x86-64-lava-sc7180-trogdor-wormdingler-rev1-boe
+
msm:apq8016:
extends:
- .lava-igt:arm64
diff --git a/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-fails.txt b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-fails.txt
new file mode 100644
index 000000000000..4af93eeeaf99
--- /dev/null
+++ b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-fails.txt
@@ -0,0 +1,23 @@
+core_setmaster@master-drop-set-user,Fail
+kms_color@ctm-0-25,Fail
+kms_color@ctm-0-50,Fail
+kms_color@ctm-0-75,Fail
+kms_color@ctm-blue-to-red,Fail
+kms_color@ctm-green-to-red,Fail
+kms_color@ctm-negative,Fail
+kms_color@ctm-red-to-blue,Fail
+kms_color@ctm-signed,Fail
+kms_color@gamma,Fail
+kms_color@legacy-gamma,Fail
+kms_cursor_legacy@cursor-vs-flip-toggle,Fail
+kms_cursor_legacy@cursor-vs-flip-varying-size,Fail
+kms_flip@flip-vs-modeset-vs-hang,Fail
+kms_flip@flip-vs-panning-vs-hang,Fail
+kms_invalid_mode@overflow-vrefresh,Fail
+kms_lease@lease-uevent,Fail
+kms_pipe_crc_basic@compare-crc-sanitycheck-nv12,Fail
+kms_plane@pixel-format,Fail
+kms_plane@pixel-format-source-clamping,Fail
+kms_plane_alpha_blend@alpha-7efc,Fail
+kms_plane_alpha_blend@coverage-7efc,Fail
+kms_plane_alpha_blend@coverage-vs-premult-vs-constant,Fail
diff --git a/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-skips.txt b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-skips.txt
new file mode 100644
index 000000000000..5f2c09c4dc17
--- /dev/null
+++ b/drivers/gpu/drm/ci/xfails/msm-sc7180-trogdor-wormdingler-rev1-boe-skips.txt
@@ -0,0 +1,30 @@
+# Suspend to RAM seems to be broken on this machine
+#.*suspend.*
+
+# Skip driver specific tests
+^amdgpu.*
+nouveau_.*
+^panfrost.*
+^v3d.*
+^vc4.*
+^vmwgfx*
+
+# Skip intel specific tests
+gem_.*
+i915_.*
+tools_test.*
+kms_dp_link_training.*
+
+# Currently fails and causes coverage loss for other tests
+# since core_getversion also fails.
+core_hotunplug.*
+
+# IGT issue. is_joiner_mode() should return false for non-Intel hardware.
+# https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/162
+kms_display_modes@extended-mode-basic
+kms_display_modes@mst-extended-mode-negative
+
+# sc7180 does not have APRIV, so memptrs is not protected.
+# (Preemption is not supported on devices that do not have
+# APRIV, so this is ok)
+msm/msm_mapping@memptrs
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Claude review: drm/ci: add sc7180-trogdor-wormdingler-rev1-boe
2026-02-24 8:10 [PATCH v1] drm/ci: add sc7180-trogdor-wormdingler-rev1-boe Vignesh Raman
2026-02-27 5:32 ` Claude review: " Claude Code Review Bot
@ 2026-02-27 5:32 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-02-27 5:32 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/ci: add sc7180-trogdor-wormdingler-rev1-boe
Author: Vignesh Raman <vignesh.raman@collabora.com>
Patches: 1
Reviewed: 2026-02-27T15:32:25.181663
---
This is a single patch adding CI test infrastructure for a new Qualcomm sc7180-trogdor-wormdingler-rev1-boe device. The patch follows the established patterns from existing sc7180-trogdor variants (lazor-limozeen, kingoftown) and is straightforward CI enablement. The DTS source file exists in the kernel tree, and both Kconfig options (`CONFIG_DRM_PANEL_BOE_TV101WUM_NL6`, `CONFIG_GPIO_SHARED_PROXY`) are valid upstream symbols.
The patch has a dependency on another series (noted in the changelog) which explains why it doesn't apply cleanly. There is one clear bug in the skips file and one item worth questioning.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm/ci: add sc7180-trogdor-wormdingler-rev1-boe
2026-02-24 8:10 [PATCH v1] drm/ci: add sc7180-trogdor-wormdingler-rev1-boe Vignesh Raman
@ 2026-02-27 5:32 ` Claude Code Review Bot
2026-02-27 5:32 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-02-27 5:32 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Bug: Suspend skip pattern is commented out**
In `msm-sc7180-trogdor-wormdingler-rev1-boe-skips.txt`:
```
# Suspend to RAM seems to be broken on this machine
#.*suspend.*
```
The `#` prefix on `.*suspend.*` makes it a comment, so suspend tests will **not** be skipped despite the preceding comment saying suspend is broken. Compare with the equivalent in `msm-sc7180-trogdor-kingoftown-skips.txt` where the pattern is active:
```
# Suspend to RAM seems to be broken on this machine
.*suspend.*
```
This should be `.*suspend.*` (without the leading `#`), otherwise broken suspend tests will run and likely cause CI failures or hangs.
**Questionable: `kms_invalid_mode@overflow-vrefresh` in fails vs skips**
This test is listed in the wormdingler **fails** file:
```
kms_invalid_mode@overflow-vrefresh,Fail
```
But in the kingoftown **skips** file, it is explicitly skipped with the explanation:
```
# It causes other tests to fail, so skip it.
kms_invalid_mode@overflow-vrefresh
```
Since both devices share the same sc7180 SoC, if this test causes other tests to fail on kingoftown, it likely does the same on wormdingler. Having it as an expected failure rather than a skip means it will still run and potentially cause cascading failures in other tests, reducing overall CI coverage. It should probably be moved to the skips file with the same rationale.
**Minor: Missing kingoftown skips that may also apply**
The kingoftown skips file includes two entries not present in wormdingler:
```
# Timeout occurs
kms_flip@2x-wf_vblank-ts-check
# Hangs the machine
kms_cursor_crc@cursor-random-max-size
```
Since these are sc7180-trogdor siblings sharing the same GPU, it's worth confirming these tests don't also timeout/hang on wormdingler. If the wormdingler test results show these pass cleanly, then their absence is correct; if not, they should be added.
**test.yml job definition looks correct**
The job follows the established pattern: extends `.msm-sc7180`, sets `DEVICE_TYPE`, `DTB`, `GPU_VERSION`, and `RUNNER_TAG`. The `parallel: 6` matches kingoftown. No issues here.
**arm64.config and build.sh additions look correct**
- `CONFIG_DRM_PANEL_BOE_TV101WUM_NL6=y` is appropriate for the BOE panel on this board variant.
- `CONFIG_GPIO_SHARED_PROXY=y` is a valid Kconfig symbol (exists in `drivers/gpio/Kconfig`).
- The DTB path in `build.sh` matches the existing DTS file in `arch/arm64/boot/dts/qcom/`.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-27 5:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24 8:10 [PATCH v1] drm/ci: add sc7180-trogdor-wormdingler-rev1-boe Vignesh Raman
2026-02-27 5:32 ` Claude review: " Claude Code Review Bot
2026-02-27 5:32 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox