From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu/buddy: Introduce gpu_buddy_assert() for kunit-aware assertions Date: Fri, 27 Feb 2026 15:09:14 +1000 Message-ID: In-Reply-To: <20260224132506.2631528-2-sanjay.kumar.yadav@intel.com> References: <20260224132506.2631528-2-sanjay.kumar.yadav@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu/buddy: Introduce gpu_buddy_assert() for kunit-aware assertions Author: Sanjay Yadav Patches: 3 Reviewed: 2026-02-27T15:09:14.390252 --- This is a single-patch series introducing a `gpu_buddy_assert()` macro to the gpu buddy allocator (a renamed/refactored version of `drm_buddy`). The macro unifies the existing ad-hoc pattern of `WARN_ON()` + optional `kunit_fail_current_test()` into a consistent helper. The patch is clean, well-motivated, and the commit message clearly explains the rationale including why `gpu_buddy_block_trim()`'s WARN_ON is left untouched. The condition inversions at each call site are all correct, the `#include` restructuring is appropriate, and the macro avoids double-evaluation. No functional issues found. A few minor observations below, but nothing blocking. --- Generated by Claude Code Patch Reviewer