From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/client: Do not destroy NULL modes
Date: Fri, 27 Feb 2026 14:35:50 +1000 [thread overview]
Message-ID: <review-overall-20260224221227.69126-2-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260224221227.69126-2-jonathan.cavitt@intel.com>
Overall Series Review
Subject: drm/client: Do not destroy NULL modes
Author: Jonathan Cavitt <jonathan.cavitt@intel.com>
Patches: 2
Reviewed: 2026-02-27T14:35:50.430766
---
This is a single-patch submission fixing a potential NULL pointer dereference in `drm_client_modeset_probe()`. The fix is correct but could be slightly improved. The issue is real: when any of `crtcs`, `modes`, `offsets`, or `enabled` fail to allocate, the code jumps to `out:` and calls `modes_destroy(dev, modes, connector_count)`, which iterates `modes[]` unconditionally — dereferencing a NULL pointer if `modes` itself failed to allocate.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-27 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 22:12 [PATCH] drm/client: Do not destroy NULL modes Jonathan Cavitt
2026-02-25 7:52 ` Ville Syrjälä
2026-02-27 4:35 ` Claude review: " Claude Code Review Bot
2026-02-27 4:35 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260224221227.69126-2-jonathan.cavitt@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox