From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/client: Do not destroy NULL modes Date: Fri, 27 Feb 2026 14:35:50 +1000 Message-ID: In-Reply-To: <20260224221227.69126-2-jonathan.cavitt@intel.com> References: <20260224221227.69126-2-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/client: Do not destroy NULL modes Author: Jonathan Cavitt Patches: 2 Reviewed: 2026-02-27T14:35:50.430766 --- This is a single-patch submission fixing a potential NULL pointer dereferen= ce in `drm_client_modeset_probe()`. The fix is correct but could be slightl= y improved. The issue is real: when any of `crtcs`, `modes`, `offsets`, or = `enabled` fail to allocate, the code jumps to `out:` and calls `modes_destr= oy(dev, modes, connector_count)`, which iterates `modes[]` unconditionally = =E2=80=94 dereferencing a NULL pointer if `modes` itself failed to allocate. --- Generated by Claude Code Patch Reviewer