From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: Turn heaps into modules
Date: Fri, 27 Feb 2026 13:12:02 +1000 [thread overview]
Message-ID: <review-overall-20260225-dma-buf-heaps-as-modules-v1-0-2109225a090d@kernel.org> (raw)
In-Reply-To: <20260225-dma-buf-heaps-as-modules-v1-0-2109225a090d@kernel.org>
Overall Series Review
Subject: dma-buf: heaps: Turn heaps into modules
Author: Maxime Ripard <mripard@kernel.org>
Patches: 22
Reviewed: 2026-02-27T13:12:02.708329
---
This series by Maxime Ripard converts the CMA and system dma-buf heaps from built-in-only to tristate (module-capable) Kconfig symbols. The approach is straightforward: (1) reverse the dependency so the kernel core stores reserved CMA regions and the heap module iterates over them, (2) export the necessary CMA and dma-buf symbols, and (3) add the standard `MODULE_*` macros.
The series is generally well-structured and the design decision to invert the registration flow (kernel stores CMA regions, heap module queries them) is sound and cleanly resolves the built-in-to-module dependency.
There are a few issues worth raising, most notably: neither heap has a `module_exit` function, and the `__init` annotations on the CMA heap functions are fine for built-in but become effectively no-ops for modules (which is safe but worth a note). One ordering concern exists with `rmem_cma_areas` not being `__initdata` while the old `dma_areas` was.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 3:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 16:41 [PATCH 0/7] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-02-25 16:41 ` [PATCH 1/7] dma: contiguous: Turn heap registration logic around Maxime Ripard
2026-02-25 19:32 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 2/7] mm: cma: Export cma_alloc and cma_release Maxime Ripard
2026-02-25 19:34 ` T.J. Mercier
2026-02-26 10:25 ` David Hildenbrand (Arm)
2026-02-26 10:38 ` Maxime Ripard
2026-02-26 10:49 ` David Hildenbrand (Arm)
2026-02-26 16:58 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 3/7] mm: cma: Export cma_get_name Maxime Ripard
2026-02-25 19:34 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 4/7] mm: cma: Export dma_contiguous_default_area Maxime Ripard
2026-02-25 19:52 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 5/7] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-02-25 19:53 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 6/7] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-02-25 19:54 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 7/7] dma-buf: heaps: system: " Maxime Ripard
2026-02-25 19:55 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 18:51 ` [PATCH 0/7] dma-buf: heaps: Turn heaps into modules John Stultz
2026-02-26 10:18 ` Maxime Ripard
2026-02-26 18:03 ` John Stultz
2026-02-27 3:12 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 10:13 [PATCH v3 0/8] " Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260225-dma-buf-heaps-as-modules-v1-0-2109225a090d@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox