From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: Turn heaps into modules Date: Fri, 27 Feb 2026 13:12:02 +1000 Message-ID: In-Reply-To: <20260225-dma-buf-heaps-as-modules-v1-0-2109225a090d@kernel.org> References: <20260225-dma-buf-heaps-as-modules-v1-0-2109225a090d@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dma-buf: heaps: Turn heaps into modules Author: Maxime Ripard Patches: 22 Reviewed: 2026-02-27T13:12:02.708329 --- This series by Maxime Ripard converts the CMA and system dma-buf heaps from built-in-only to tristate (module-capable) Kconfig symbols. The approach is straightforward: (1) reverse the dependency so the kernel core stores reserved CMA regions and the heap module iterates over them, (2) export the necessary CMA and dma-buf symbols, and (3) add the standard `MODULE_*` macros. The series is generally well-structured and the design decision to invert the registration flow (kernel stores CMA regions, heap module queries them) is sound and cleanly resolves the built-in-to-module dependency. There are a few issues worth raising, most notably: neither heap has a `module_exit` function, and the `__init` annotations on the CMA heap functions are fine for built-in but become effectively no-ops for modules (which is safe but worth a note). One ordering concern exists with `rmem_cma_areas` not being `__initdata` while the old `dma_areas` was. --- Generated by Claude Code Patch Reviewer