From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/ras: Fix type size of remainder argument Date: Fri, 27 Feb 2026 14:18:28 +1000 Message-ID: In-Reply-To: <20260225014317.work.103-kees@kernel.org> References: <20260225014317.work.103-kees@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amd/ras: Fix type size of remainder argument Author: Kees Cook Patches: 2 Reviewed: 2026-02-27T14:18:28.692244 --- This is a single-patch fix from Kees Cook that addresses a real type-safety bug in `ras_core_convert_timestamp_to_time()`. The function passes an `int *` cast to `uint64_t *` into `div64_u64_rem()`, which expects a `u64 *remainder` parameter. This is a legitimate problem: on 64-bit platforms the store through the `uint64_t *` pointer will write 8 bytes into a 4-byte `int`, corrupting the adjacent stack variable, and on big-endian systems the wrong half of the 64-bit value would land in the `int`. The fix is straightforward and correct. The patch is well-motivated by a real compiler warning (`-Warray-bounds`) and has a proper `Fixes:` tag. **Verdict: The patch looks good and should be accepted.** --- Generated by Claude Code Patch Reviewer