public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/dumb-buffers: document that it's only for linear FB
Date: Fri, 27 Feb 2026 13:56:36 +1000	[thread overview]
Message-ID: <review-overall-20260225061315.1003811-1-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260225061315.1003811-1-zhengxingda@iscas.ac.cn>

Overall Series Review

Subject: drm/dumb-buffers: document that it's only for linear FB
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 7
Reviewed: 2026-02-27T13:56:36.617491

---

This is a single documentation-only patch that adds clarifying text to the dumb buffers kernel-doc comment in `drm_dumb_buffers.c`. The intent is good — making it explicit that dumb buffers are meant for linear layouts only, and noting existing (but discouraged) AFBC abuse. The patch is straightforward and low-risk.

However, there are some wording and tone issues worth addressing.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-27  3:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  6:13 [PATCH] drm/dumb-buffers: document that it's only for linear FB Icenowy Zheng
2026-02-25  7:26 ` Thomas Zimmermann
2026-02-25  7:38   ` Icenowy Zheng
2026-02-25  7:47     ` Thomas Zimmermann
2026-02-25  8:10       ` Icenowy Zheng
2026-02-25  8:34         ` Thomas Zimmermann
2026-02-25 14:13           ` Icenowy Zheng
2026-02-27  3:56 ` Claude Code Review Bot [this message]
2026-02-27  3:56 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260225061315.1003811-1-zhengxingda@iscas.ac.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox