From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add LCD and LVDS controller for sama7d65 SoC Date: Fri, 27 Feb 2026 13:48:28 +1000 Message-ID: In-Reply-To: <20260225085430.480052-1-manikandan.m@microchip.com> References: <20260225085430.480052-1-manikandan.m@microchip.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add LCD and LVDS controller for sama7d65 SoC Author: Manikandan Muralidharan Patches: 8 Reviewed: 2026-02-27T13:48:28.796406 --- This 6-patch series adds LCD (XLCDC) and LVDS controller device tree nodes = for the Microchip SAMA7D65 SoC, updates the LVDS binding, and enables relev= ant defconfig options. The series is straightforward but has a **critical f= unctional issue**: the LCD controller DT node uses `compatible =3D "microch= ip,sama7d65-xlcdc"` without a fallback compatible, and the DRM driver (`atm= el_hlcdc_dc.c`) does **not** have this compatible in its `atmel_hlcdc_of_ma= tch` table. The DRM driver probe uses `of_match_node(atmel_hlcdc_of_match, = dev->dev->parent->of_node)` to find the layer descriptors =E2=80=94 this lo= okup will fail, and the display controller will not work at runtime. The MF= D driver side is fine (it already has the match), but the DRM side is broke= n. Additionally, the series mixes an unrelated touchscreen config change into = a display-focused series, has a minor DT style issue, and uses a non-standa= rd patch ordering. --- Generated by Claude Code Patch Reviewer