From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: Fix resource leaks
Date: Fri, 27 Feb 2026 13:15:06 +1000 [thread overview]
Message-ID: <review-overall-20260225145154.14168-1-ethantidmore06@gmail.com> (raw)
In-Reply-To: <20260225145154.14168-1-ethantidmore06@gmail.com>
Overall Series Review
Subject: drm/amdgpu: Fix resource leaks
Author: Ethan Tidmore <ethantidmore06@gmail.com>
Patches: 1
Reviewed: 2026-02-27T13:15:06.912896
---
This is a single patch (v2) that converts `ioremap()`/`iounmap()` of `adev->rmmio` to `devm_ioremap()` to fix resource leaks on error paths in `amdgpu_device_init()`. While the Smatch warning about the error-path leaks is legitimate, this fix is **incorrect and introduces a use-after-free bug** that is worse than the original leak.
The fundamental problem is a **lifetime mismatch**: `devm_ioremap()` ties the resource lifetime to the PCI `struct device`, but `adev->rmmio` is accessed from the DRM device `.release` callback (`amdgpu_driver_release_kms` → `amdgpu_device_fini_sw`), which can run **long after** the PCI driver has unbound and devm resources have been freed.
**NAK** — this needs a different approach.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 14:51 [PATCH v2] drm/amdgpu: Fix resource leaks Ethan Tidmore
2026-02-27 3:15 ` Claude Code Review Bot [this message]
2026-02-27 3:15 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260225145154.14168-1-ethantidmore06@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox