From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/amdgpu: Fix resource leaks
Date: Fri, 27 Feb 2026 14:17:10 +1000 [thread overview]
Message-ID: <review-overall-202602251459.1jr0PuUf-lkp@intel.com> (raw)
In-Reply-To: <202602251459.1jr0PuUf-lkp@intel.com>
Overall Series Review
Subject: Re: [PATCH] drm/amdgpu: Fix resource leaks
Author: kernel test robot <lkp@intel.com>
Patches: 2
Reviewed: 2026-02-27T14:17:10.577336
---
This single patch converts `adev->rmmio` from `ioremap()` to `devm_ioremap()` and removes the manual `iounmap()` calls. While the intent to fix resource leaks on error paths is valid (the Smatch warning is real), the approach has **serious correctness problems** related to the device lifecycle and hot-unplug handling. The patch should **not be applied** in its current form.
The core issue: the patch removes `adev->rmmio = NULL` assignments that serve as **guards** in the driver's teardown logic, and changes the unmap timing from explicit driver-controlled teardown to implicit device-release-time cleanup, which fundamentally breaks the hot-unplug code path.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 4:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 1:44 [PATCH] drm/amdgpu: Fix resource leaks Ethan Tidmore
2026-02-25 6:36 ` kernel test robot
2026-02-27 4:17 ` Claude Code Review Bot [this message]
2026-02-27 4:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-202602251459.1jr0PuUf-lkp@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox