From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] drm/amdgpu: Fix resource leaks Date: Fri, 27 Feb 2026 14:17:10 +1000 Message-ID: In-Reply-To: <202602251459.1jr0PuUf-lkp@intel.com> References: <202602251459.1jr0PuUf-lkp@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] drm/amdgpu: Fix resource leaks Author: kernel test robot Patches: 2 Reviewed: 2026-02-27T14:17:10.577336 --- This single patch converts `adev->rmmio` from `ioremap()` to `devm_ioremap()` and removes the manual `iounmap()` calls. While the intent to fix resource leaks on error paths is valid (the Smatch warning is real), the approach has **serious correctness problems** related to the device lifecycle and hot-unplug handling. The patch should **not be applied** in its current form. The core issue: the patch removes `adev->rmmio = NULL` assignments that serve as **guards** in the driver's teardown logic, and changes the unmap timing from explicit driver-controlled teardown to implicit device-release-time cleanup, which fundamentally breaks the hot-unplug code path. --- Generated by Claude Code Patch Reviewer