public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo
@ 2026-02-25 17:34 Krzysztof Kozlowski
  2026-02-25 19:42 ` Dmitry Baryshkov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-25 17:34 UTC (permalink / raw)
  To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
	Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Fix obvious model typo (SM8650->SM8750) in the description.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 .../devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml
index d55fda9a523e..a38c2261ef1a 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml
@@ -10,7 +10,7 @@ maintainers:
   - Krzysztof Kozlowski <krzk@kernel.org>
 
 description:
-  SM8650 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
+  SM8750 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
   DPU display controller, DSI and DP interfaces etc.
 
 $ref: /schemas/display/msm/mdss-common.yaml#
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo
  2026-02-25 17:34 [PATCH] dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo Krzysztof Kozlowski
@ 2026-02-25 19:42 ` Dmitry Baryshkov
  2026-02-27  3:08 ` Claude review: " Claude Code Review Bot
  2026-02-27  3:08 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-02-25 19:42 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
	Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, dri-devel,
	freedreno, devicetree, linux-kernel

On Wed, Feb 25, 2026 at 06:34:20PM +0100, Krzysztof Kozlowski wrote:
> Fix obvious model typo (SM8650->SM8750) in the description.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml
> index d55fda9a523e..a38c2261ef1a 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8750-mdss.yaml
> @@ -10,7 +10,7 @@ maintainers:
>    - Krzysztof Kozlowski <krzk@kernel.org>
>  
>  description:
> -  SM8650 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
> +  SM8750 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
>    DPU display controller, DSI and DP interfaces etc.
>  
>  $ref: /schemas/display/msm/mdss-common.yaml#
> -- 

Fixes: 6b93840116df ("dt-bindings: display/msm: qcom,sm8750-mdss: Add SM8750")


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo
  2026-02-25 17:34 [PATCH] dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo Krzysztof Kozlowski
  2026-02-25 19:42 ` Dmitry Baryshkov
  2026-02-27  3:08 ` Claude review: " Claude Code Review Bot
@ 2026-02-27  3:08 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-02-27  3:08 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-02-27T13:08:20.142531

---

This is a single trivial patch that fixes an obvious copy-paste typo in a devicetree binding description. The file `qcom,sm8750-mdss.yaml` had its description incorrectly referencing "SM8650" instead of "SM8750". The title of the binding already correctly says "Qualcomm SM8750 Display MDSS", confirming this is indeed a typo carried over from the SM8650 binding when creating the SM8750 variant.

The patch is correct, minimal, and straightforward. No issues found.

**Verdict: Patch looks good. No concerns.**

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo
  2026-02-25 17:34 [PATCH] dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo Krzysztof Kozlowski
  2026-02-25 19:42 ` Dmitry Baryshkov
@ 2026-02-27  3:08 ` Claude Code Review Bot
  2026-02-27  3:08 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-02-27  3:08 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Status: Good to go**

The change is a one-line fix in the YAML description field:

```yaml
-  SM8650 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
+  SM8750 MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like
```

I verified against the kernel tree that:
- The file title at line 7 already reads `title: Qualcomm SM8750 Display MDSS`
- The `compatible` property at line 20 reads `const: qcom,sm8750-mdss`
- Only the `description` field at line 13 had the stale "SM8650" reference

This was clearly a copy-paste artifact from the SM8650 binding when the SM8750 binding was created. The fix is correct and complete.

Reviewed-by tag warranted. No further changes needed.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-27  3:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-25 17:34 [PATCH] dt-bindings: display/msm: qcom,sm8750-mdss: Fix model typo Krzysztof Kozlowski
2026-02-25 19:42 ` Dmitry Baryshkov
2026-02-27  3:08 ` Claude review: " Claude Code Review Bot
2026-02-27  3:08 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox