Claude review: drm/edid: add CTA Video Format Data Block support

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/edid: add CTA Video Format Data Block support
Author: Hamza Mahfooz <someguy@effective-light.com>
Patches: 1
Reviewed: 2026-02-27T13:05:57.108727

---

This is a single patch (v6) adding CTA-861-I Video Format Data Block (VFDB) parsing and the Optimized Video Timings (OVT) algorithm to the DRM EDID subsystem. The patch is substantial (~465 lines added) and implements a complex timing algorithm. The overall goal is sound and the data tables appear correctly transcribed from CTA-861-I. However, the patch has several bugs of varying severity, plus a significant readability issue in the core algorithm that makes review and future maintenance difficult.

**Key issues found:**
1. **Bug (medium):** Wrong constant in step 8 vsync_position calculation
2. **Bug (medium):** u32 multiplication overflow in step 4 for high resolutions
3. **Bug (low-medium):** Missing `EXPORT_SYMBOL` despite header declaration
4. **Readability:** The goto-based "jump into middle of loop" pattern in `calculate_ovt_pixel_clock_rate` is extremely hard to follow
5. **Minor:** Missing `case 144` in step 1, typo in comment

---

---
Generated by Claude Code Patch Reviewer