From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/edid: add CTA Video Format Data Block support Date: Fri, 27 Feb 2026 13:05:57 +1000 Message-ID: In-Reply-To: <20260225175709.408010-1-someguy@effective-light.com> References: <20260225175709.408010-1-someguy@effective-light.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/edid: add CTA Video Format Data Block support Author: Hamza Mahfooz Patches: 1 Reviewed: 2026-02-27T13:05:57.108727 --- This is a single patch (v6) adding CTA-861-I Video Format Data Block (VFDB) parsing and the Optimized Video Timings (OVT) algorithm to the DRM EDID subsystem. The patch is substantial (~465 lines added) and implements a complex timing algorithm. The overall goal is sound and the data tables appear correctly transcribed from CTA-861-I. However, the patch has several bugs of varying severity, plus a significant readability issue in the core algorithm that makes review and future maintenance difficult. **Key issues found:** 1. **Bug (medium):** Wrong constant in step 8 vsync_position calculation 2. **Bug (medium):** u32 multiplication overflow in step 4 for high resolutions 3. **Bug (low-medium):** Missing `EXPORT_SYMBOL` despite header declaration 4. **Readability:** The goto-based "jump into middle of loop" pattern in `calculate_ovt_pixel_clock_rate` is extremely hard to follow 5. **Minor:** Missing `case 144` in step 1, typo in comment --- --- Generated by Claude Code Patch Reviewer