From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Use a different name for latest firmware Date: Fri, 27 Feb 2026 12:57:27 +1000 Message-ID: In-Reply-To: <20260225193022.2707525-1-lizhi.hou@amd.com> References: <20260225193022.2707525-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Use a different name for latest firmware Author: Lizhi Hou Patches: 3 Reviewed: 2026-02-27T12:57:27.075175 --- This is a single-patch fix for a power-off issue caused by loading the latest firmware with a legacy driver. The approach is to introduce a new firmware filename (`npu_7.sbin`) for the latest firmware and implement a fallback mechanism: try the new firmware first, then fall back to the old `npu.sbin`. The concept is sound, but the implementation has several issues ranging from missing `const` qualifiers, to using `request_firmware()` (which logs errors) for an expected-to-fail probe, to a silently dropped `MODULE_FIRMWARE` entry, and an error message that now prints a directory instead of a filename. --- Generated by Claude Code Patch Reviewer