From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Use a different name for latest firmware
Date: Fri, 27 Feb 2026 12:53:21 +1000 [thread overview]
Message-ID: <review-overall-20260225204752.2711734-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260225204752.2711734-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Use a different name for latest firmware
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 3
Reviewed: 2026-02-27T12:53:21.622485
---
This is a single-patch fix for a firmware compatibility issue where a legacy driver loading the latest firmware causes a power-off problem. The approach — renaming the latest firmware to `npu_7.sbin` and using a fallback chain — is reasonable and follows a common kernel pattern. However, the patch has several issues that should be addressed: a missing `const` qualifier, a misleading error message after the semantic change to `fw_path`, a missing `MODULE_FIRMWARE` entry for the `17f0_20` variant, and the `XDNA_INFO` message being printed on every successful probe.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 20:47 [PATCH V2] accel/amdxdna: Use a different name for latest firmware Lizhi Hou
2026-02-25 20:49 ` Mario Limonciello (AMD) (kernel.org)
2026-02-25 21:56 ` Lizhi Hou
2026-02-27 2:53 ` Claude Code Review Bot [this message]
2026-02-27 2:53 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 19:30 [PATCH V1] " Lizhi Hou
2026-02-27 2:57 ` Claude review: " Claude Code Review Bot
2026-02-27 2:57 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260225204752.2711734-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox