From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Use a different name for latest firmware Date: Fri, 27 Feb 2026 12:53:21 +1000 Message-ID: In-Reply-To: <20260225204752.2711734-1-lizhi.hou@amd.com> References: <20260225204752.2711734-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Use a different name for latest firmware Author: Lizhi Hou Patches: 3 Reviewed: 2026-02-27T12:53:21.622485 --- This is a single-patch fix for a firmware compatibility issue where a legac= y driver loading the latest firmware causes a power-off problem. The approa= ch =E2=80=94 renaming the latest firmware to `npu_7.sbin` and using a fallb= ack chain =E2=80=94 is reasonable and follows a common kernel pattern. Howe= ver, the patch has several issues that should be addressed: a missing `cons= t` qualifier, a misleading error message after the semantic change to `fw_p= ath`, a missing `MODULE_FIRMWARE` entry for the `17f0_20` variant, and the = `XDNA_INFO` message being printed on every successful probe. --- --- Generated by Claude Code Patch Reviewer