From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: amdgpu: fix panic on old GPUs
Date: Fri, 27 Feb 2026 12:46:56 +1000 [thread overview]
Message-ID: <review-overall-20260225215013.11224-1-rosenp@gmail.com> (raw)
In-Reply-To: <20260225215013.11224-1-rosenp@gmail.com>
Overall Series Review
Subject: amdgpu: fix panic on old GPUs
Author: Rosen Penev <rosenp@gmail.com>
Patches: 3
Reviewed: 2026-02-27T12:46:56.998022
---
This is a stable backport request for two upstream commits (b515dcb0dc4e and 9d73b107a61b) targeting 6.12 and 6.6 kernels. The patches fix a panic/black screen regression on GCN 1 GPUs (SI, KV) caused by incomplete backporting of DC display configuration changes. The upstream commit that was backported (7009e3af0474) expected `pm_display_cfg` to be populated by the legacy DPM code, but the commits that actually populate it were never backported, leading to the crash.
The patches are faithful reproductions of the upstream code and are appropriate for stable. I have one observation about a latent bug that exists in the upstream code itself (not introduced by this backport).
**Verdict: Looks correct for stable backport purposes. One pre-existing upstream issue noted below.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-27 2:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 21:50 [PATCH for 6.12 and 6.6 0/2] amdgpu: fix panic on old GPUs Rosen Penev
2026-02-25 21:50 ` [PATCH 1/2] drm/amd/display: Add pixel_clock to amd_pp_display_configuration Rosen Penev
2026-02-27 2:46 ` Claude review: " Claude Code Review Bot
2026-02-25 21:50 ` [PATCH 2/2] drm/amd/pm: Use pm_display_cfg in legacy DPM (v2) Rosen Penev
2026-02-27 2:46 ` Claude review: " Claude Code Review Bot
2026-02-27 2:46 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260225215013.11224-1-rosenp@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox