From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add continuation record support Date: Fri, 27 Feb 2026 12:21:58 +1000 Message-ID: In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: gsp: add continuation record support Author: Eliot Courtney Patches: 11 Reviewed: 2026-02-27T12:21:58.086630 --- This is a well-structured 9-patch series from Eliot Courtney at NVIDIA that= adds continuation record support to the nova-core GSP command queue. The s= eries enables sending RPCs larger than 16 pages (64KB) by splitting them in= to multiple queue elements. The patches are logically ordered with incremen= tal preparation steps (1-7) leading to the core implementation (8) and test= s (9). The overall design is sound: a `SplitState` type determines whether splitti= ng is needed, a `SplitCommand` enum transparently wraps the original comman= d so that small commands still write directly to the queue (zero-copy), whi= le large commands stage their variable payload into a `KVVec` buffer and th= en dispatch it in chunks. The continuation record protocol itself is simple= =E2=80=94 just a header followed by raw payload bytes. The code quality is good, the abstractions are clean, and the tests cover t= he important boundary conditions. I have a few observations, mostly minor. --- Generated by Claude Code Patch Reviewer