From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel: New driver for NXP's Neutron NPU Date: Fri, 27 Feb 2026 12:10:07 +1000 Message-ID: In-Reply-To: <20260226-neutron-v1-0-46eccb3bb50a@nxp.com> References: <20260226-neutron-v1-0-46eccb3bb50a@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel: New driver for NXP's Neutron NPU Author: Ioana Ciocoi-Radulescu Patches: 13 Reviewed: 2026-02-27T12:10:07.145982 --- This is a v1 submission of a new accel driver for the NXP Neutron NPU on i.MX95. The series is well-structured with a clean patch split: GEM DMA helper extension, documentation, dt-bindings, core driver, GEM, mailbox, job submission, debugfs logging, and DTS. The driver is straightforward and follows patterns from the ethosu driver. However, there are several issues that need to be addressed: missing firmware validation that could lead to out-of-bounds reads, a latent bug where `job->type` is never explicitly set, missing locking around the log buffer, UAPI concerns (wrong ioctl direction macros, unvalidated pad fields), and an `of_match_ptr()` usage that shouldn't be there. Overall the driver is reasonably clean for a v1 but needs another round to fix the issues below. --- Generated by Claude Code Patch Reviewer