From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Enable mdss1 Display Port for Qualcomm lemans-ride platform
Date: Fri, 27 Feb 2026 12:26:29 +1000 [thread overview]
Message-ID: <review-overall-20260226111322.250176-1-quic_mkuntuma@quicinc.com> (raw)
In-Reply-To: <20260226111322.250176-1-quic_mkuntuma@quicinc.com>
Overall Series Review
Subject: Enable mdss1 Display Port for Qualcomm lemans-ride platform
Author: Mani Chandana Ballary Kuntumalla <quic_mkuntuma@quicinc.com>
Patches: 5
Reviewed: 2026-02-27T12:26:29.297745
---
This 2-patch series adds device tree nodes for the second Mobile Display Subsystem (mdss1) on the Qualcomm SA8775P (Lemans) SoC, including DPTX0/DPTX1 controllers and eDP PHYs, and then enables them on the lemans-ride board.
The series is well-structured and closely follows the existing mdss0 patterns. The OPP table refactoring (moving them to root level for sharing between mdss0 and mdss1) is clean and was requested by the reviewer. The node structure, clock assignments, interrupt numbering, and port wiring all look correct and consistent with mdss0.
The series depends on an unmerged series (https://lore.kernel.org/all/20260128114853.2543416-1-quic_riteshk@quicinc.com/) which likely introduces `MASTER_MDP_CORE1_0`/`MASTER_MDP_CORE1_1` interconnect masters and `GCC_DISP1_HF_AXI_CLK`, and may also add the "ref" clock to the mdss0 PHYs. This dependency should be clearly noted for merge ordering.
**One notable concern**: The mdss1 eDP PHY nodes include a third clock (`GCC_EDP_REF_CLKREF_EN` / "ref") that the current upstream mdss0 eDP PHY nodes do not have. If the dependency series doesn't also add this clock to the mdss0 PHY nodes, this creates an inconsistency. Otherwise, the series looks ready to go.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-27 2:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 11:13 [PATCH v4 0/2] Enable mdss1 Display Port for Qualcomm lemans-ride platform Mani Chandana Ballary Kuntumalla
2026-02-26 11:13 ` [PATCH v4 1/2] arm64: dts: qcom: lemans: add mdss1 display device nodes Mani Chandana Ballary Kuntumalla
2026-02-26 14:43 ` Konrad Dybcio
2026-02-27 2:26 ` Claude review: " Claude Code Review Bot
2026-02-26 11:13 ` [PATCH v4 2/2] arm64: dts: qcom: lemans-ride: Enable mdss1 display Port Mani Chandana Ballary Kuntumalla
2026-02-26 14:37 ` Konrad Dybcio
2026-02-27 2:26 ` Claude review: " Claude Code Review Bot
2026-02-27 2:26 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260226111322.250176-1-quic_mkuntuma@quicinc.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox