From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: dw-hdmi: Replace calls to deprecated HDMI/audio detection functions Date: Fri, 27 Feb 2026 12:14:28 +1000 Message-ID: In-Reply-To: <20260226120626.108378-1-karanja99erick@gmail.com> References: <20260226120626.108378-1-karanja99erick@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: dw-hdmi: Replace calls to deprecated HDMI/audio detect= ion functions Author: Erick Karanja Patches: 1 Reviewed: 2026-02-27T12:14:28.991376 --- This is a single patch (v2) that attempts to remove deprecated `drm_detect_= hdmi_monitor()` and `drm_detect_monitor_audio()` calls from the dw-hdmi bri= dge driver. The idea is correct in principle =E2=80=94 `drm_edid_connector_= update()` is already called after `dw_hdmi_edid_read()` returns (at line 25= 08), and it populates `connector->display_info.is_hdmi` and `connector->dis= play_info.has_audio`. However, **the patch is incomplete and will cause a f= unctional regression**: it removes the assignments to `hdmi->sink_is_hdmi` = and `hdmi->sink_has_audio` but does **not** update the multiple consumers o= f those fields to use `connector->display_info` instead. **NAK as-is.** The remaining usages will read zero-initialized `false` valu= es, meaning: - HDMI sinks will always be treated as DVI (no infoframes, no limited range= RGB) - Audio will never be enabled - The struct fields themselves become dead code --- Generated by Claude Code Patch Reviewer