From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm/tests: Fix build failure on PREEMPT_RT
Date: Fri, 27 Feb 2026 11:52:16 +1000 [thread overview]
Message-ID: <review-overall-20260226151228.256003-1-dev@lankhorst.se> (raw)
In-Reply-To: <20260226151228.256003-1-dev@lankhorst.se>
Overall Series Review
Subject: drm/ttm/tests: Fix build failure on PREEMPT_RT
Author: Maarten Lankhorst <dev@lankhorst.se>
Patches: 1
Reviewed: 2026-02-27T11:52:16.138579
---
This is a single-patch fix for a build failure in the TTM kunit tests when `CONFIG_PREEMPT_RT` is enabled. The fix is straightforward and correct: it replaces direct access to the internal `mutex` base member of a `ww_mutex` with the proper `ww_mutex_lock()`/`ww_mutex_unlock()` API calls. On PREEMPT_RT kernels, the underlying mutex implementation changes from a standard `mutex` to an `rt_mutex`, so accessing `.lock.base` directly breaks.
The patch is well-motivated (reported by the kernel test robot), small, and low-risk.
**Recommendation: Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 1:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 15:12 [PATCH] drm/ttm/tests: Fix build failure on PREEMPT_RT Maarten Lankhorst
2026-02-27 1:52 ` Claude Code Review Bot [this message]
2026-02-27 1:52 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-04 8:56 [PATCH v2] " Maarten Lankhorst
2026-03-05 3:40 ` Claude review: " Claude Code Review Bot
2026-03-05 3:40 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260226151228.256003-1-dev@lankhorst.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox