From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sun4i: Fix resource leaks Date: Fri, 27 Feb 2026 11:44:46 +1000 Message-ID: In-Reply-To: <20260226163836.10335-1-ethantidmore06@gmail.com> References: <20260226163836.10335-1-ethantidmore06@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/sun4i: Fix resource leaks Author: Ethan Tidmore Patches: 1 Reviewed: 2026-02-27T11:44:46.295713 --- This is a single-patch submission fixing a resource leak in the sun4i display backend driver. The fix is **correct and straightforward**: when `devm_regmap_init_mmio()` fails, the original code returned directly, leaking three clocks (bus_clk, mod_clk, ram_clk) and leaving the reset control deasserted. The patch properly sets `ret` and jumps to the existing `err_disable_ram_clk` cleanup label, which chains through all necessary cleanup. The patch is minimal, well-targeted, and has an appropriate Fixes tag. There is one minor observation about a pre-existing issue worth noting, but it does not affect the correctness of this patch. **Verdict: Patch looks good.** --- Generated by Claude Code Patch Reviewer