From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sitronix/st7586: fix bad pixel data due to byte swap
Date: Tue, 03 Mar 2026 14:04:23 +1000 [thread overview]
Message-ID: <review-overall-20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> (raw)
In-Reply-To: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com>
Overall Series Review
Subject: drm/sitronix/st7586: fix bad pixel data due to byte swap
Author: David Lechner <dlechner@baylibre.com>
Patches: 2
Reviewed: 2026-03-03T14:04:23.047090
---
This is a single-patch bug fix for the ST7586 Sitronix display driver. The ST7586 is a monochrome controller that packs 3 pixels per byte (8-bit data), which is non-standard compared to typical MIPI DBI displays that use 16-bit RGB565.
A prior commit (`df3fb27a74a4`) refactored how the MIPI DBI subsystem controls the SPI bits-per-word for pixel transfers, replacing the indirect `swap_bytes` workaround with an explicit `write_memory_bpw` field. That refactoring inadvertently broke the ST7586 by leaving it with the default 16-bit transfer width, causing every group of 3 pixel columns to be swapped on the display.
The fix is straightforward, correct, and well-placed. **Reviewed-by worthy.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 4:30 [PATCH] drm/sitronix/st7586: fix bad pixel data due to byte swap David Lechner
2026-03-02 7:46 ` Thomas Zimmermann
2026-03-03 4:04 ` Claude Code Review Bot [this message]
2026-03-03 4:04 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox