From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sitronix/st7586: fix bad pixel data due to byte swap Date: Tue, 03 Mar 2026 14:04:23 +1000 Message-ID: In-Reply-To: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> References: <20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24cd28@baylibre.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/sitronix/st7586: fix bad pixel data due to byte swap Author: David Lechner Patches: 2 Reviewed: 2026-03-03T14:04:23.047090 --- This is a single-patch bug fix for the ST7586 Sitronix display driver. The ST7586 is a monochrome controller that packs 3 pixels per byte (8-bit data), which is non-standard compared to typical MIPI DBI displays that use 16-bit RGB565. A prior commit (`df3fb27a74a4`) refactored how the MIPI DBI subsystem controls the SPI bits-per-word for pixel transfers, replacing the indirect `swap_bytes` workaround with an explicit `write_memory_bpw` field. That refactoring inadvertently broke the ST7586 by leaving it with the default 16-bit transfer width, causing every group of 3 pixel columns to be swapped on the display. The fix is straightforward, correct, and well-placed. **Reviewed-by worthy.** --- Generated by Claude Code Patch Reviewer