From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: add missing MODULE_DEVICE_ID definitions
Date: Tue, 03 Mar 2026 14:09:11 +1000 [thread overview]
Message-ID: <review-overall-20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com> (raw)
In-Reply-To: <20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm: add missing MODULE_DEVICE_ID definitions
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-03-03T14:09:11.569887
---
This is a single, straightforward patch that adds missing `MODULE_DEVICE_TABLE(of, ...)` declarations to five MSM DRM sub-drivers (DP, DSI, DSI PHY, HDMI, HDMI PHY). The `drm/msm` module bundles all these sub-drivers into a single `.ko`, and without these declarations, udev's module autoloading won't trigger when only these devices appear in the device tree. The fix is correct and necessary for proper module autoloading.
The patch is minimal, mechanical, and correct. One minor naming concern is noted below but is not a blocking issue.
**Verdict: Looks good. Recommend merge.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-03 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 17:20 [PATCH v2] drm/msm: add missing MODULE_DEVICE_ID definitions Dmitry Baryshkov
2026-03-03 4:09 ` Claude review: " Claude Code Review Bot
2026-03-03 4:09 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox