From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: add missing MODULE_DEVICE_ID definitions Date: Tue, 03 Mar 2026 14:09:11 +1000 Message-ID: In-Reply-To: <20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com> References: <20260228-msm-device-id-v2-1-24b085919444@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: add missing MODULE_DEVICE_ID definitions Author: Dmitry Baryshkov Patches: 1 Reviewed: 2026-03-03T14:09:11.569887 --- This is a single, straightforward patch that adds missing `MODULE_DEVICE_TABLE(of, ...)` declarations to five MSM DRM sub-drivers (DP, DSI, DSI PHY, HDMI, HDMI PHY). The `drm/msm` module bundles all these sub-drivers into a single `.ko`, and without these declarations, udev's module autoloading won't trigger when only these devices appear in the device tree. The fix is correct and necessary for proper module autoloading. The patch is minimal, mechanical, and correct. One minor naming concern is noted below but is not a blocking issue. **Verdict: Looks good. Recommend merge.** --- Generated by Claude Code Patch Reviewer