Claude review: Add some sensor data to amdxdna

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add some sensor data to amdxdna
Author: "Mario Limonciello (AMD)" <superm1@kernel.org>
Patches: 4
Reviewed: 2026-03-03T14:37:39.281145

---

This 2-patch series adds sensor data reporting to the amdxdna (NPU accelerator) driver by hooking into the AMD PMF (Platform Management Framework) driver to obtain realtime NPU power and column utilization metrics. The UAPI enum `DRM_AMDXDNA_QUERY_SENSORS` already exists but had no handler — this series provides the implementation.

The overall approach is reasonable, but there are several design issues:

1. **Patch 2 breaks the API contract established by patch 1** — patch 1 requires a buffer for 1 sensor, patch 2 retroactively requires space for 1+N sensors or returns `-EINVAL`. Userspace cannot discover the required buffer size without trial-and-error.
2. **The macro abstraction is messy** — patch 1 introduces `AIE2_GET_PMF_NPU_DATA` then patch 2 immediately adds a parallel `AIE2_GET_PMF_NPU_METRICS`, leaving the former as dead code.
3. **The `unitm` / `units` semantics are inconsistent** for the power sensor.

---

---
Generated by Claude Code Patch Reviewer